How I Read A Pull Request
SMRTR summary
Software engineer Kevin Murphy has turned code reviewing into something resembling a daily meditation practice, developing an intricate system that treats pull requests like archaeological artifacts requiring careful excavation. His method involves strategic timing throughout the day, from morning momentum-builders to karma-generating reviews after submitting his own work.
The real revelation lies in his "test-driven review" approach. Rather than diving straight into implementation code, he deliberately reads tests first, treating them as roadmaps that reveal what the author considered important or struggled with most.
"I'm not encumbered with knowing the implementation that may justify the test's complexity," he explains, allowing him to spot potential design issues without being swayed by existing code.
His process mirrors journalistic investigation, asking the fundamental questions of when, what, why, who, where, and how. He scrolls through changes like speed-reading a novel to grasp the overall shape before diving into details, always circling back to ensure the code meets its stated goals.
This methodical approach has accelerated his professional growth while helping colleagues push work toward production more effectively.
SMRTR provides this summary for quick context. The original article belongs to Daily.dev.
Read the original article